[Freeipa-devel] [PATCH] 0227-2-automount-UI

[Adam Young]

On 05/26/2011 09:30 AM, Endi Sukma Dewata wrote:
> On 5/25/2011 7:58 PM, Adam Young wrote:
>>> 17. The adder dialog boxes for map and key don't have a title. The
>>> titles should be defined in internal.py and the ipa_init.json needs
>>> to be regenerated.
>
>> Fixed
>
> The ipa_init.json doesn't seem to be updated yet.
>
>> More changes in this patch. I combined most of the search and nested
>> search facet into a single fact, by adding a field : managed_entity.
>> THat way, the facet can still track the entity to which it belongs, but
>> it performs searches on the managed entity. Most of the code from
>> nested_entity_facet could then be removed.
>>
>> I also fixed search and the back to list links.
>
> 19. The unit test failed.
Fixed in pushed version
>
> 20. When viewing a map, 'back to list' will bring you to locations
>     instead of maps.

Deliberate.  This is the right behaviour.  What is questionable is the 
placement on the screen
>
> 21. Please see the attached patch. The managed_entity variable and
>     neseted_search_facet can be removed.
Will do in a future patch.


ACKed in IRC by edewata and pushed to master