[Freeipa-devel] [PATCH] 788 remove automountinformation from automount dns

[Dmitri Pal]

On 05/26/2011 04:51 PM, Adam Young wrote:
> On 05/23/2011 02:38 PM, Rob Crittenden wrote:
>> In an attempt to support multiple direct maps we always included the
>> automountinformation in the key dn. This makes showing keys
>> impossible a bit of a catch-22. You want to get the mount info but to
>> get it you need the mount info.
>>
>> This patch drops requiring automountinfo but if provided it'll use it
>> to make the dn. This way we can have backwards compatibility for any
>> existing maps but going forward only direct maps will have the info
>> in it.
>>
>> --key is still required when dealing with keys, no way around that
>> without doing a major API change, migrating data, etc.
>>
>> ticket 1229
>>
>> rob
>>
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
> This approach still breaks many of the assumptions that the UI is
> built upon.  First, the primary key is now description, which is will
> look odd to people.  Second, the methods for show, add, and delete
> will require custom code.  I think that, if ever there was a time to
> break the automount scheme, it is up front now when we don't have that
> embedded a user base.  I'd rather get it right this time around then
> have to support an difficult implementation for a long time.

I thought we are clear about this.
The patch needs to be reworked to allow --key or key as 3rd parameter
and one of the two is required.
Am I missing something?
Adam didn't you just test the old patch that should have been withdrawn?

>
>
>
> The error doesn't get marshalled properly in JSON.
>
> u May 26 15:44:44 2011] [error] ipa: INFO:
> admin at SERVER15.AYOUNG.BOSTON.DEVEL.REDHAT.COM:
> automountkey_find(u'default', u'auto.mnt', u'', all=False): SUCCESS
> [Thu May 26 15:44:46 2011] [error] ipa: ERROR: jsonserver.__call__():
> [Thu May 26 15:44:46 2011] [error] Traceback (most recent call last):
> [Thu May 26 15:44:46 2011] [error]   File
> "/usr/lib/python2.7/site-packages/ipaserver/rpcserver.py", line 248,
> in __call__
> [Thu May 26 15:44:46 2011] [error]     response =
> self.wsgi_execute(environ)
> [Thu May 26 15:44:46 2011] [error]   File
> "/usr/lib/python2.7/site-packages/ipaserver/rpcserver.py", line 230,
> in wsgi_execute
> [Thu May 26 15:44:46 2011] [error]     params =
> self.Command[name].args_options_2_params(*args, **options)
> [Thu May 26 15:44:46 2011] [error]   File
> "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 483, in
> args_options_2_params
> [Thu May 26 15:44:46 2011] [error]     raise
> MaxArgumentError(name=self.name, count=self.max_args)
> [Thu May 26 15:44:46 2011] [error] MaxArgumentError: command
> 'automountkey_show' takes at most 2 arguments
> (END)
>
>
>
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110526/e134549c/attachment.htm>