[Freeipa-devel] [PATCH] #2038 modify salt creation

[Nalin Dahyabhai]

On Thu, Nov 03, 2011 at 06:26:15PM -0400, Simo Sorce wrote:
> As stated in the bug in order to attain better interoperability with
> Windows clients we need to change the way we generate the random salt.

Nack.  The data in a krb5_data is of type 'char', and if it's signed,
the math used here doesn't produce a printable result.  Might also want
to increase KRB5P_SALT_SIZE.

Nalin