[Freeipa-devel] [PATCH] 162 Fix coverity issues in client CLI tools

Rob Crittenden rcritten at redhat.com
Fri Nov 11 18:41:58 UTC 2011


Martin Kosek wrote:
> This patch fixes 2 coverity issues:
>   * ipa-client/config.c: CID 11090: Resource leak
>   * ipa-client/ipa-getkeytab.c: CID 11018: Unchecked return value
>
> https://fedorahosted.org/freeipa/ticket/2035

You don't need to test a variable before you free it, so you can just 
call free(data).

Since we are capturing the kerberos error should it be displayed as well 
in ipa-getkeytab?

rob




More information about the Freeipa-devel mailing list