[Freeipa-devel] [PATCH 53/53] ticket 2022 - modify codebase to utilize IPALogManager, obsoletes logging

John Dennis jdennis at redhat.com
Tue Nov 22 16:23:31 UTC 2011


On 11/21/2011 03:30 AM, Martin Kosek wrote:
> Hello Jonh,
>
> the log calls look OK now. I think it will be much easier to use that
> way.
>
> Your patch 0052 and this new patch 0001 applies to current master now.
> (btw. it would be great if they followed FreeIPA patch policy, i.e.
> freeipa-jdennis-52-....patch - it would be easier for me to find and
> manipulate these files)

Fixed. This attachment exactly mirrors the original with the patch 
number information.

>
> However, pylint discovered 2 problems, I don't think this will fly:
>
> $ ./make-lint
> ipapython/ipa_log_manager.py:176: [E0602,
> IPALogManager.configure_from_env] Undefined variable 'parse_log_level'
> ipapython/ipa_log_manager.py:190: [E0602,
> IPALogManager.configure_from_env] Undefined variable 'parse_log_level'

Fixed.


-- 
John Dennis <jdennis at redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0053-ticket-2022-modify-codebase-to-utilize-IPALogManager.patch
Type: text/x-patch
Size: 165101 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20111122/1faebc89/attachment.bin>


More information about the Freeipa-devel mailing list