[Freeipa-devel] [PATCH] 8 Add DNS service records for Windows
Martin Kosek
mkosek at redhat.com
Tue Nov 29 13:16:12 UTC 2011
On Mon, 2011-11-28 at 18:16 +0100, Sumit Bose wrote:
> On Mon, Nov 28, 2011 at 02:26:00PM +0200, Alexander Bokovoy wrote:
> > On Fri, 25 Nov 2011, Sumit Bose wrote:
> > > On Wed, Nov 23, 2011 at 05:33:42PM -0500, Rob Crittenden wrote:
> > > > Alexander Bokovoy wrote:
> > > > >Hi Sumit,
> > > > >
> > > > >On Fri, 14 Oct 2011, Sumit Bose wrote:
> > > > >>>It would make more clear what is the default and that it is really
> > > > >>>optional setting -- I'm thinking from the perspective of maintenance
> > > > >>>of the code in future.
> > > > >>
> > > > >>Thank you for your comments, new version attached.
> > > > >Finally got to test it. ACK.
> > > > >
> > > >
> > > > pushed to master.
> > >
> > > Sorry, I think you pushed the first version and not -3- which was ACKed
> > > by Alexander.
> > Hm. Sumit, could you please rebase -3- on top of current master
> > HEAD+(1)?
> >
> > I tried that briefly myself and failed.
> >
> > (1) Right now I'm also getting make-lint failing due to more strict
> > PyLint in F16/Rawhide and those seems to be corect and also affect
> > adtrustinstance.
> >
> > I'm sending the patch shortly, so please rebase on top of it.
>
> ok, rebased version is attached. To push this upstream you still have to
> revert the wrong commit.
>
> bye,
> Sumit
I reverted the wrong version of patch so that Sumit can provide correct
rebased version:
master: ac45a5eee8382ab62b7c8b7c78c2bca36e5bf8a6
Martin
More information about the Freeipa-devel
mailing list