[Freeipa-devel] [PATCH] 49 Work around pkisilent bugs

[Rob Crittenden]

Jan Cholasta wrote:
> Work around pkisilent bugs.
>
> Check directory manager password for invalid characters.
> (https://bugzilla.redhat.com/show_bug.cgi?id=658641)
>
> Shell-escape pkisilent command-line arguments.
> (https://bugzilla.redhat.com/show_bug.cgi?id=741180)
>
> Once the bugs are fixed, the workarounds should be removed and pkisilent
> minimum required version should be bumped.
>
> https://fedorahosted.org/freeipa/ticket/1636
>
> Honza

Potential nack. The code here works I just found a couple more corner cases.

Some special characters in the subject base also cause pkisilent to 
fail. ampersand is one. I wonder if we need to catch this as well.

Tab in the password will cause a failure.

rob