[Freeipa-devel] [PULL REQUEST, master] Platform-specific adaptation

Alexander Bokovoy abokovoy at redhat.com
Mon Sep 12 14:49:50 UTC 2011


On Mon, 12 Sep 2011, Martin Kosek wrote:
> Good job! This all looks very good, I found no installation error in
> various scenarios I tried. I only found a problem with mixed tabs-spaces
> indentation. You introduced it at least in install/tools/ipactl. You can
> easily check these cases with:
> 
> $ ./make-lint --enable-noerror | grep W0312
> ipa-client/ipa-install/ipa-client-install:221: [W0312] Found indentation with tabs instead of spaces
> ipa-client/ipa-install/ipa-client-install:237: [W0312] Found indentation with tabs instead of spaces
> ...
> install/tools/ipactl:194: [W0312] Found indentation with tabs instead of spaces
> install/tools/ipactl:203: [W0312] Found indentation with tabs instead of spaces
> install/tools/ipactl:241: [W0312] Found indentation with tabs instead of spaces
> ...
> 
> We don't have to fix the old indentation problems right in your patches
> but we should not introduce new tab-spaces problems as they have a
> potential to cause nasty problems.
I believe I fixed all whitespace problems, old and new. I eneded up 
with a separate commit due to scale of it. It is pushed to both 
platform and platform-master branches on fedorapeople repo.

-- 
/ Alexander Bokovoy




More information about the Freeipa-devel mailing list