[Freeipa-devel] [PATCH] 268 Fixed labels for run-as users and groups.

Endi Sukma Dewata edewata at redhat.com
Tue Sep 13 06:04:45 UTC 2011


On 9/12/2011 8:43 AM, Petr Vobornik wrote:
> On 09/10/2011 02:21 AM, Endi Sukma Dewata wrote:
>> The labels for the run-as users and groups tables in sudo rule details
>> page have been modified to improve the clarity.
>>
>> Ticket #1752
>
> Use of 'that.label = that.label | ...' in association_table_widget is
> affecting other labels besides that specified in spec object. In Who
> section of sudo rule label "User Group" is changed to "Groups". Because
> this way it uses default label retrieval method in widget
> (IPA.get_entity_param) instead of metadata.objects.[other_entity].label.
> This isn't entirely wrong, but param labels aren't always consistent
> with entity.labels.
>
> Otherwise its OK.

The labels from entity parameter are actually more appropriate. I've 
updated the patch to use them instead. I also fixed some of the labels 
(the run-as group label & doc is incorrect).

-- 
Endi S. Dewata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-edewata-0268-2-Fixed-labels-for-run-as-users-and-groups.patch
Type: text/x-patch
Size: 64293 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110913/302a8133/attachment.bin>


More information about the Freeipa-devel mailing list