[Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it
Alexander Bokovoy
abokovoy at redhat.com
Tue Sep 13 13:33:52 UTC 2011
On Tue, 13 Sep 2011, Stephen Gallagher wrote:
> > > File "/usr/lib/python2.7/site-packages/SSSDConfig.py", line 1207, in import_config
> > > fd = open(configfile, 'r')
> > > IOError: [Errno 2] No such file or directory: '/etc/sssd/sssd.conf'
> > Right, we need to fallback to new sssd.conf in case of any exception,
> > not only for ParsingError.
> Actually, that's not necessarily true. Do we want to fall back on
> permission error, for instance? This could result in clobbering an
> existing file (if for example the existing sssd.conf's SELinux context
> is wrong, preventing reading, but when we create a new one and save it
> in place later we have the right context and it replaces the old one).
Let's define what we want to see here.
1. There is no sssd.conf -> create new one (unlikely for existing SSSD
installation -- if we went to this path, we already found SSSD
installed)
2. There is sssd.conf -> modify existing one
2.1. Can't open for write -> report error
2.2. Can't open and read due to parsing error -> create new one
...
What are other cases?
> Admittedly, it's a contrived example, but where contrived examples
> exist, so can real issues.
True.
--
/ Alexander Bokovoy
More information about the Freeipa-devel
mailing list