[Freeipa-devel] [PATCH] 270 Fixed posix group checkbox.

[Petr Vobornik]

On 09/15/2011 02:06 AM, Endi Sukma Dewata wrote:
> In the adder dialog for groups the checkbox has been modified to use
> the correct field name "nonposix" and be checked by default.
>
> Note: This is a temporary fix to minimize the changes due to release
> schedule. Eventually the field label will be changed into "Non-POSIX
> group" and the checkbox will be unchecked by default, which is more
> consistent with CLI.
>
> Ticket #1799

The temporary workaround approach is good but there might be a minor 
issue. One test for this patch fails. It is because current 
implementation sets checked attribute to false for all values except 
'TRUE'. Previous implementation set checked to true if there was any 
value except 'FALSE'. I tried to search for all usages of checkbox and 
found that this behaviour is not a problem right now, but I'm not sure 
if it won't be in the future (but there would have to be changes in save 
method). So if its OK, after a test correction I would consider it ACKed.


-- 
Petr Vobornik