[Freeipa-devel] [PATCH] 276 Fixed problem enabling/disabling DNS zone.

Endi Sukma Dewata edewata at redhat.com
Thu Sep 22 17:23:38 UTC 2011


On 9/22/2011 6:59 AM, Petr Vobornik wrote:
> On 09/17/2011 12:18 AM, Endi Sukma Dewata wrote:
>> The details facet for DNS zone has been modified to use dnszone-
>> enable/disable for idnszoneactive and dnszone-mod for other fields.
>>
>> Ticket #1813
>
> ACK

Pushed to master and ipa-2-1.

> Btw it doesn't matter (besides performance) if you move 'if
> (!field.is_dirty()) continue;' in sudo and hbac facet couple lines lower
> because to execute member_operation you have to fulfil two conditions,
> which won't be never reached - name of the association fields changed so
> 'if (categories[field.name])' will be never true. Even if it would be
> the next condition ('values[0] == 'all) won't be either because of weird
> implementation of table_widget.save method.
> Anyway if it would be functional it would be IMO bad - checking line
> doesn't imply that user wants it to be deleted right now. Even if
> marking the line could be used only for deletion.
>
> This code should be cleaned in the future (erased or fixed).

As mentioned on IRC, this fixes a regression in the UI when changing the 
category. The two conditions (remove_values and has_values) are set by 
different fields (category and table), that's why the logic is kind of 
complicated. The server side will be fixed in ticket #1440. Once that's 
fixed we no longer need this code so it can be cleaned up.

-- 
Endi S. Dewata




More information about the Freeipa-devel mailing list