[Freeipa-devel] [PATCH] 881 don't log OTP in client install log

Rob Crittenden rcritten at redhat.com
Fri Sep 23 13:21:47 UTC 2011


Martin Kosek wrote:
> On Fri, 2011-09-23 at 09:07 -0400, Rob Crittenden wrote:
>> Martin Kosek wrote:
>>> On Thu, 2011-09-22 at 11:55 -0400, Rob Crittenden wrote:
>>>> Obfuscate the one-time password in the client installer log.
>>>>
>>>> rob
>>>
>>> NACK. You missed a case when OTP is interactively prompted (-W parameter
>>> is passed).
>>>
>>> Martin
>>>
>>
>> Nice catch, updated patch
>>
>> rob
>
> Umh, nice try. I think you wanted to read nolog password from
> getpass.getpass output and not options.password.
>
> Martin
>

That's what I get for doing things quickly. This one should work.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-881-3-client.patch
Type: text/x-patch
Size: 2513 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110923/46501c4d/attachment.bin>


More information about the Freeipa-devel mailing list