[Freeipa-devel] [PATCH] 017 Fixed: Column header for attributes table should be full, width

Petr Vobornik pvoborni at redhat.com
Mon Sep 26 09:25:13 UTC 2011


On 09/26/2011 08:15 AM, Endi Sukma Dewata wrote:
> On 9/23/2011 11:05 AM, Petr Vobornik wrote:
>> https://fedorahosted.org/freeipa/ticket/1841
>>
>> The column header for the attributes table (IPA.attributes_widget) does
>> not cover the entire width of the table. This problem appears in the
>> adder dialog and details page for permissions, self-service permissions,
>> and delegations.
>
> This is an improvement over the existing code, but there's still an
> issue. In other tables like in search page there's a space between one
> column header to another. In this patch there is no space. It looks like
> the header of the 'Attribute' column occupies the entire line (use
> Firebug to select the element).

I've reworked the patch. It's simplified and it uses already build-in 
functionality.

> For this particular case it's just a minor issue. But suppose we have
> more columns it could be a problem because the other headers probably
> will occupy the entire line too.
>
> We can push the patch as is if you agree.

> I think ideally we want to convert the IPA.attributes_widget to inherit from IPA.table_widget. The
> table widget should calculate the column widths properly.
I agree.

-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0017-1-Fixed-Column-header-for-attributes-table-should-be-f.patch
Type: text/x-patch
Size: 2823 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110926/48885b79/attachment.bin>


More information about the Freeipa-devel mailing list