[Freeipa-devel] [PATCH] 45 Check that install hostname matches the server hostname

Jan Cholasta jcholast at redhat.com
Mon Sep 26 14:59:50 UTC 2011


On 26.9.2011 13:22, Martin Kosek wrote:
> On Mon, 2011-09-26 at 11:54 +0200, Jan Cholasta wrote:
>> On 26.9.2011 10:59, Martin Kosek wrote:
>>> On Mon, 2011-09-12 at 09:50 +0200, Jan Cholasta wrote:
>>>> On 7.9.2011 15:13, Rob Crittenden wrote:
>>>>> Jan Cholasta wrote:
>>>>>> On 6.9.2011 19:49, Rob Crittenden wrote:
>>>>>>> Jan Cholasta wrote:
>>>>>>>> https://fedorahosted.org/freeipa/ticket/1717
>>>>>>>>
>>>>>>>> Honza
>>>>>>>
>>>>>>> nack, what if there are multiple interfaces and you want IPA to use one
>>>>>>> (that doesn't happen to be the system hostname one)?
>>>>>>>
>>>>>>> rob
>>>>>>
>>>>>> Then the user configures the system hostname to match the hostname of
>>>>>> the interface. Or should we configure it automatically from the install?
>>>>>>
>>>>>> Honza
>>>>>>
>>>>>
>>>>> We can't dictate which interface matches the hostname. At most we can
>>>>> warn about this, but not fail to install.
>>>>>
>>>>> rob
>>>>
>>>> Changed to print a warning message instead of raising an error.
>>>>
>>>> Honza
>>>>
>>>
>>> With this patch, ipa-replica-prepare always reports the warning:
>>>
>>> # ipa-replica-prepare vm-050.idm.lab.bos.redhat.com
>>> Warning: The host name 'vm-050.idm.lab.bos.redhat.com' does not match the system host name 'vm-134.idm.lab.bos.redhat.com'.
>>>            Some services may not work properly.
>>> Directory Manager (existing master) password:
>>>
>>> Reopening 1717.
>>>
>>> Martin
>>>
>>
>> Fixed. Patch attached.
>>
>> Honza
>>
>
> Looks functional, but I would suggest changing the option name. Maybe
> its just me but I couldn't tell what no_system_hostname option does
> until I studied the change.
>
> The negative logic may be confusing, I would change it something like
> system_hostname_check=False ->  system hostname check is not executed.
> Plus, lets write a doc string for this function it is documented
> properly.
>
> Martin
>

Option name changed, docstring added.

Honza

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-45a.1-hostname-check.patch
Type: text/x-patch
Size: 2910 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110926/367a62fd/attachment.bin>


More information about the Freeipa-devel mailing list