[Freeipa-devel] [PATCH] 73 Check whether the default user group is POSIX when adding new user with --noprivate

[Martin Kosek]

On Wed, 2012-04-04 at 18:50 +0200, Jan Cholasta wrote:
> On 3.4.2012 13:04, Martin Kosek wrote:
> > On Tue, 2012-04-03 at 13:02 +0200, Martin Kosek wrote:
> >> On Tue, 2012-04-03 at 11:58 +0200, Jan Cholasta wrote:
> >>> https://fedorahosted.org/freeipa/ticket/2572
> >>>
> >>> Honza
> >>>
> >>
> >> NACK.
> >>
> >> This creates a regression:
> >>
> >> # ipa group-show foogroup
> >>    Group name: foogroup
> >>    Description: foo
> >>    GID: 358800017
> >>
> >> # ipa user-add --first=Foo --last=Bar fbar5 --gidnumber=358800017 --noprivate
> >> ------------------
> >> Added user "fbar5"
> >> ------------------
> >>    User login: fbar5
> >>    First name: Foo
> >>    Last name: Bar
> >>    Full name: Foo Bar
> >>    Display name: Foo Bar
> >>    Initials: FB
> >>    Home directory: /home/fbar5
> >>    GECOS field: Foo Bar
> >>    Login shell: /bin/sh
> >>    Kerberos principal: fbar5 at IDM.LAB.BOS.REDHAT.COM
> >>    UID: 358800019
> >>    GID: 358800012
> >>    Password: False
> >>    Member of groups: ipausers
> >>    Kerberos keys available: False
> >>
> >> # id fbar5
> >> uid=358800019(fbar5) gid=358800012(ipausers) groups=358800012(ipausers)
> >>
> >> Custom user group (GID) was overwritten.
> >>
> >> I think we also want a test case for this situation.
> >>
> >> Martin
> >>
> >
> > ... and we also want to have the new error message(s) i18n-able.
> >
> > Martin
> >
> 
> Updated patch attached.
> 
> Honza
> 

ACK. Thanks for all the tests.

Pushed to master, ipa-2-2.

Martin