[Freeipa-devel] [PATCH 71] improve handling of ds instances during uninstall

[Alexander Bokovoy]

On Thu, 05 Apr 2012, John Dennis wrote:
> On 04/05/2012 01:26 AM, Alexander Bokovoy wrote:
>> On Wed, 04 Apr 2012, John Dennis wrote:
>>> +                # Strip off prefix
>>> +                instance = basename[len(instance_prefix):]
>>> +                # Must be non-empty
>>> +                if instance:
>>> +                    instances.append(basename[len(instance_prefix):])
>> You have already generated basename[len(instance_prefix):], may be it
>> could be as simple as
>>      instances.append(instance)
>> here?
>> 
> 
> Good catch, yup that's what I meant to write, must have been a 
> cut-n-paste mistake.
> 
> Revised patch attached.
ACK now.

-- 
/ Alexander Bokovoy