[Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_host_plugin.py

[Tomas Babej]

I implemented your suggestions. New version of the patch attached.

----- Original Message -----
From: "Petr Viktorin" <pviktori at redhat.com>
To: freeipa-devel at redhat.com
Sent: Friday, July 27, 2012 1:23:54 PM
Subject: Re: [Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_host_plugin.py

On 07/27/2012 01:13 PM, Tomas Babej wrote:
> Hi,
>
> this patch simply checks if ipa-join exists in ipa-client folder, if not, skips tests relying on it.
> Uses nose.plugin.skip.
>
> https://fedorahosted.org/freeipa/ticket/2905
>
> Tomas Babej
>


Hello,
This would be better done in class setup, so you don't have to repeat it 
in every method. Look at XMLRPC_test.setUpClass() in xmlrpc_test.py for 
isnpiration.

While you're at it, it would be good to move the mkstemp() call into 
setUpClass as well, so that importing the module doesn't have 
unnecessary side effects.

-- 
Petr³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel at redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0001-2-Adds-check-for-existence-of-ipa-client-ipa-join-exec.patch
Type: text/x-patch
Size: 2561 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120802/98509f5b/attachment.bin>