[Freeipa-devel] [PATCH] 186-192 Web UI: Group external member support

[Petr Vobornik]

On 08/06/2012 10:14 PM, Endi Sukma Dewata wrote:
> ACK.

Attaching all patches. Patches 186-189 are changed or rebased. Rest is 
intact.

>
> The patches work, but I have some comments:
>
> 1. Would it be better to use radio buttons to define mutually exclusive
> options? Something like this:
>
>    Group type: (o) Normal
>                ( ) External
>                ( ) POSIX
>                    GID: [            ]

Patch 186 reworked.

>
> 2. If you decide to use radio buttons for the adder dialog you might
> want to use similar layout in the details page.

Patch 189 reworked.

>
> 3. Minor thing, the "posix" in "Change to posix group" probably should
> be capitalized to be consistent with the "POSIX group" field label. Feel
> free to fix before push.

Fixed.

>
> 4. I don't have the environment to test patch #192 but the code looks fine.
>
> 5. I noticed this problem, but I couldn't reproduce it anymore. When I
> specified a GID in the group adder dialog, the value seemed to be
> ignored, so the GID would always be generated. Also the GID wasn't
> validated. Probably just a glitch.
>
I didn't notice it.

-- 
Petr Vobornik


-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0186-1-Add-external-group.patch
Type: text/x-patch
Size: 5367 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120810/9e7d29c8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0187-1-Make-group-external.patch
Type: text/x-patch
Size: 5528 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120810/9e7d29c8/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0188-1-Make-group-posix.patch
Type: text/x-patch
Size: 3208 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120810/9e7d29c8/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0189-1-Display-group-type.patch
Type: text/x-patch
Size: 5144 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120810/9e7d29c8/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0190-Attribute-facet.patch
Type: text/x-patch
Size: 12054 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120810/9e7d29c8/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0191-Group-external-member-facet.patch
Type: text/x-patch
Size: 1316 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120810/9e7d29c8/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0192-Read-only-external-facet-for-non-external-groups.patch
Type: text/x-patch
Size: 3640 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120810/9e7d29c8/attachment-0006.bin>