[Freeipa-devel] [PATCH] 0003-2 Handle SSSD restart crash more gently.

[Martin Kosek]

On 08/14/2012 03:12 PM, Tomas Babej wrote:
> Issue resolved.
> 
> Tomas
> 
> ----- Original Message -----
> From: "Martin Kosek" <mkosek at redhat.com>
> To: "Tomas Babej" <tbabej at redhat.com>
> Cc: freeipa-devel at redhat.com
> Sent: Tuesday, August 14, 2012 9:26:03 AM
> Subject: Re: [Freeipa-devel] [PATCH] 0003 Handle SSSD restart crash more gently.
> 
> On 08/07/2012 06:14 PM, Tomas Babej wrote:
>> Sorry, I forgot to attach the patch.
>>
>> ----- Original Message -----
>> From: "Tomas Babej" <tbabej at redhat.com>
>> To: freeipa-devel at redhat.com
>> Sent: Tuesday, August 7, 2012 5:58:32 PM
>> Subject: [PATCH] Handle SSSD restart crash more gently.
>>
>> Hi,
>>
>> In ipa-client-install, failure of restart of sssd service no longer
>> causes the crash of the install process. Adds a warning message to
>> the root logger instead.
>>
>> https://fedorahosted.org/freeipa/ticket/2827
>>
>> Tomas
>>
> 
> This works fine, I see just one issue. It is better to catch for more specific
> exceptions that with the bare "except" clause. Otherwise for example in this
> case, if the sssd restart would got stuck, one could not CTRL+C it properly as
> the bare except clause would catch the appropriate exception. You may want to
> check with PEP8 on that one.
> 
> I would suggest rather catching CalledProcessError only.
> 
> Martin
> 

ACK. Pushed to master.

Martin