[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Freeipa-devel] [PATCHES] 59-65 SSH public key management



Jan Cholasta wrote:
Updated & rebased the patches.

I have also attached a patch that Rob made:


[PATCH] Don't use sets when calculating the modlist so order is preserved.

This is for the LDAP updater in particular. When adding new schema order
can be important when one objectclass depends on another via SUP.


Without this patch updates won't work.

Dne 25.1.2012 17:19, Rob Crittenden napsal(a):

Patch 61 you can drop the md5 and sha1 imports and import them from
ipalib.compat instead.

Is this OK in ipapython?

It should be, ipa-python and ipalib should be packaged together so I
think it is safe.

Turns out this change breaks ipa-upgradeconfig.

The problem is the package initializer, ipalib/__init__.py. Just importing ipalib.compat also imports a bunch of other stuff.

I wonder if moving the decode function to ipalib.util would resolve this. I'm not a big fan of duplicating that import code.

Otherwise this works ok. I tested in the ipa-2-2 branch so had to do a couple of merges, not sure if this applies cleanly to current master or not.

rob


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]