[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Freeipa-devel] [PATCH] 929 add option for ipaconfigstrig



On Wed, 2012-02-08 at 11:21 -0500, Rob Crittenden wrote:
> Martin Kosek wrote:
> > On Tue, 2012-02-07 at 08:56 -0500, Rob Crittenden wrote:
> >> Convert from a freeform string into a enumeration.
> >>
> >> Only values currently allowed are AllowLMhash and AllowNThash.
> >>
> >> To add more than one value on the command-line specify --ipaconfigstring
> >> multiple times.
> >>
> >> rob
> >
> > NACK
> >
> > 1) The patch needs rebasing (conflicts in VERSION file)
> >
> > 2) I think we should add csv=True to this parameter so that user can
> > specify pwd plugin features in a CSV format:
> >
> > # ipa config-mod --ipaconfigstring=AllowLMhash,AllowNThash
> >
> > It is much more user friendly than:
> >
> > # ipa config-mod --ipaconfigstring=AllowLMhash --ipaconfigstring=AllowNThash
> 
> Sure, good idea. Updated patch attached.
> 
> rob
> 

ACK. Pushed to master, ipa-2-2 (I needed to re-generate API.txt as csv
parameter is written there).

Martin




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]