[Freeipa-devel] [PATCH] 077 Redirection to PTR records from A, AAAA records

[Petr Vobornik]

On 02/14/2012 08:11 AM, Endi Sukma Dewata wrote:
> On 2/9/2012 7:57 AM, Petr Vobornik wrote:
>> Address column in A, AAAA DNS records was extended by redirection
>> capabilities.
>> Redirection dialog is shown after a click on a value.
>> Dialog does following steps:
>> 1) fetch all dns zones
>> 2) find most accurate reverse zone for IP address
>> 2 -fail) show error message, stop
>> 3) checks if target record exists in the zone
>> 3 -fail) show 'dns record create link', stop
>> 4) redirects
>>
>> Click on 'dns record create link':
>> 1) creates record
>> 1 -fail) show error, stop
>> 2) redirects
>>
>> https://fedorahosted.org/freeipa/ticket/1975
>
> One minor issue:
>
> 1. After redirection the breadcrumb doesn't link to the correct zone.
> Try this:
>
> a) Open the details page of an A record.
> b) Click the IP address (create the PTR record if necessary), it will
> show the PTR record.
> c) Click the reverse zone in the breadcrumb, it will go to the forward
> zone.

Hmm. It's because it was the last zone opened and the redirection 
(clicking on breadcrumb causes redirection to facet's redirection facet 
- in this case the zone) takes in consideration only a facet not an 
entry (current pkeys state). From this point of view it behaves 
correctly but I understand your point.

Are you saying, that we should change breadcrumb navigation code to take 
in consideration the current state (pkeys). If so I would rather do it 
separately.


>
> Possible improvements:
>
> 2. We can also create a link from the PTR record to go back to the A
> record.

Yep. Do you think it should be part of this patch?
>
> 3. When all of the redirection steps work correctly, the redirection
> dialog will appear and then disappear immediately. There's no time to
> read the message. I think the redirection steps should be done in the
> background after clicking the link and the dialog should only appear
> when there's an error. So it might be better to move the redirection
> code into the redirection column.

My idea behind the dialog is that if you are on slow vpn you can see 
some progress and notice that something is happening. Also it prevents 
doing other, not desired actions.

>
> 4. The dialog is an error dialog, so the dialog title could say
> something like "Unable to open PTR record". From users' perspective they
> are following a link, it's not a redirection.

I don't consider it an error dialog. The title wording can be changed to 
something more appropriate but not to error message.

>
> 5. The messages shown in the dialog can be simplified. Users don't need
> to know the detailed steps such as fetching the DNS zones, etc. If
> there's no matching reverse zone it could just say something like:
>
> Reverse DNS zone for <IP address> not found.
>
> If there's a reverse zone but no PTR record, it could say something like
> this:
>
> PTR record for <IP address> not found.
> [Create PTR Record]


Yeah, maybe it is too chatty. It may be better to display general 
"checking for PTR record with activity indicator next to it.

>
> 6. To be consistent, all user action that changes the data should be
> presented as a button. So the "Create PTR Record" above should be
> converted into a button.
>
Good point. Will do.


-- 
Petr Vobornik