[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once



On Thu, 2012-02-23 at 16:08 +0100, Jan Cholasta wrote:
> On 23.2.2012 15:29, Petr Viktorin wrote:
...
> > If we only keep one of those, the fix for #2227 should be quite easy.
> > If not (backwards compatibility), we need to document this properly,
> > test all the corner cases, and fix the UI to handle CSV escaping.
> > Since it's subtly broken in lots of places, maybe it's best to break
> > backwards compatibility and go for a simple solution now.
> >
> > Anyway, if I want to do a proper fix, CSV handling should be only done
> > on the client. Unfortunately turning off CSV handling in the server will
> > break the UI, which at places uses `join(',')` (no escaping commas, no
> > single place to change it), even though it can just send a list.
> >
> 
> +1, but I'm not sure if that's acceptable (see 
> http://www.redhat.com/archives/freeipa-devel/2012-January/msg00197.html)
> 

I tend to like this solution as well, it is true that CSV parsing is
really a client thing. Our life as a server would be much easier if we
just accept scalar values in an array, either from XMLRPC or JSON
interface. It is doable, but it would break IPAv2.x clients which then
would not be able to use CSV formatted values at all. And we want to
avoid that.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]