[Freeipa-devel] [PATCH] 14 ipa permission-add does not fail if using invalid attribute

[Rob Crittenden]

Ondrej Hamada wrote:
> When adding or modifying permission with both type and attributes
> specified, check whether the attributes are allowed for specified type.
> In case of disallowed attributes the InvalidSyntax error is raised.
>
> New tests were also added to the unit-tests.
>
> https://fedorahosted.org/freeipa/ticket/2293
>
> https://www.redhat.com/mailman/listinfo/freeipa-devel

NACK. You should use obj.object_class_config to determine if the default 
list of objectclasses comes from LDAP.

I think that may be it, otherwise the patch reads ok.

I'm very glad to see unit tests!

rob