[Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

Rob Crittenden rcritten at redhat.com
Mon Feb 27 22:16:27 UTC 2012


Martin Kosek wrote:
> On Mon, 2012-02-27 at 10:07 -0500, Rob Crittenden wrote:
>> Martin Kosek wrote:
>>> On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote:
>>>> Limit the characters in a netgroup name to alpha, digits, -, _ and .
>>>>
>>>> rob
>>>
>>> NACK.
>>>
>>> 1) The regular expressions is not correct, you forget the ending "$".
>>> Thus it matches any string with the right beginning. Like this one:
>>>
>>> # ipa netgroup-add "foo+bar" --desc=baz
>>> ipa: ERROR: Can't contact LDAP server:
>>>
>>> 2) Shouldn't we add a similar validator for hostgroups too? Netgroups
>>> are created out of hostgroups, i.e. I think they should share name
>>> restrictions.
>>>
>>> Martin
>>>
>>
>> Nice catch. Fixed both and added simple test cases.
>>
>> rob
>
> Works for me. ACK if you re-generate API.txt (patterns were
> changed/added).
>
> Martin
>

Fixed and pushed to ipa-2-2 and master

rob




More information about the Freeipa-devel mailing list