[Freeipa-devel] [PATCH] 225 Improve dnsrecord interactive help

Martin Kosek mkosek at redhat.com
Tue Feb 28 14:43:10 UTC 2012


This patch is build on top of my DNS patches 218-220
----

Add 2 new features to DNS record interactive help to increase its
usability and also make its behavior more consistent with standard
parameter interactive help:

1) Ask for missing DNS parts
When a required part of a newly added DNS record was missing, we
just returned a ValidationError. Now, the interactive help rather
asks for all missing required parts of all DNS records that were
being added by its parts.

2) Let user amend invalid part
When an interactive help asked for a DNS record part value and
user enters an invalid value, the entire interactive help exits
with an error. This may upset a user if he already entered several
correct DNS record part values. Now, the help rather tells user
what's wrong and give him an opportunity to amend the value.

https://fedorahosted.org/freeipa/ticket/2386

-------------
A demonstration of the new features:

# ipa dnsrecord-add example.com foo --mx-exchanger=mx.example.com.
MX Preference: 0    <<< we don't fail now
  Record name: foo
  MX record: 0 mx.example.com.

# ipa dnsrecord-add example.com foo
Please choose a type of DNS resource record to be added
The most common types for this type of zone are: A, AAAA

DNS resource record type: LOC
LOC Degrees Latitude: 1
[LOC Minutes Latitude]: 1000   <<< we don't fail with invalid values!
>>> LOC Minutes Latitude: can be at most 59
[LOC Minutes Latitude]: 50
[LOC Seconds Latitude]: 
LOC Direction Latitude: E
>>> LOC Direction Latitude: must be one of (u'N', u'S')
LOC Direction Latitude: N
LOC Degrees Longtitude: 2
[LOC Minutes Longtitude]: 
[LOC Seconds Longtitude]: 
LOC Direction Longtitude: E
LOC Altitude: 123
[LOC Size]: 
[LOC Horizontal Precision]: 
[LOC Vertical Precision]: 
  Record name: foo
  LOC record: 1 50 N 2 E 123.00
  MX record: 0 mx.example.com.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-225-improve-dnsrecord-interactive-help.patch
Type: text/x-patch
Size: 9335 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120228/88b7e448/attachment.bin>


More information about the Freeipa-devel mailing list