[Freeipa-devel] [PATCH] 7 Ignore srchost option in hbactest

[Ondrej Hamada]

On 01/05/2012 05:40 PM, Alexander Bokovoy wrote:
> On Thu, 05 Jan 2012, Ondrej Hamada wrote:
>> https://fedorahosted.org/freeipa/ticket/2085
>>
>> New version of SSSD begins ignoring sourcehost value of HBAC rules by
>> default. In order to match this behaviour the sourcehost option in
>> hbactest is optional now, but the value of sourcehost is ignored in all
>> rules. Every rule's sourcehost value is set to 'ALL' what turns sourchost
>> value comparation off. For every such a rule warning is displayed to
>> inform the user about changes.
>>
>> Also the unit tests for hbactest plugin were updated. Every test was
>> doubled. The second ones test the plugin without sourcehost option. They
>> are supposed to have the same result.
> Looks OK for me. One possibility to enhance the tests is to verify
> that sourcehost-based version also checks warning being set to
> something other than None.
>
> ACK
Done. I've also made one modification - warnings appear only when 
srchost option is used and unittests checks whether they've appeared. 
I've also updated the text in docstring to be mentioning srchost option 
as optional only.

-- 
Regards,

Ondrej Hamada
FreeIPA team
jabber: ohama at jabbim.cz
IRC: ohamada

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ohamada-7-1-HBAC-test-optional-sourcehost-option.patch
Type: text/x-patch
Size: 15906 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120107/6100c60f/attachment.bin>