[Freeipa-devel] [PATCH] 267 Allow relative DNS name in NS validator

[Petr Viktorin]

On 05/31/2012 04:58 PM, Martin Kosek wrote:
> On Thu, 2012-05-31 at 13:42 +0200, Petr Viktorin wrote:
>> On 05/29/2012 03:11 PM, Martin Kosek wrote:
>>> Precallback validator was failing when a zone-relative name was
>>> used as a NS record (for example record "ns" in a zone "example.com").
>>> However, this is valid in BIND and we should allow it as well.
>>>
>>> Imports in dns module had to be switched to absolute imports
>>> (available from Python 2.5) to deal with a conflict of IPA dns
>>> module and dnspython module.
>>>
>>> https://fedorahosted.org/freeipa/ticket/2630
>>>
>>
>> This works fine, but it breaks a test:
>>
>> ======================================================================
>> FAIL: test_dns[48]: dnsrecord_add: Try to add unresolvable NS record to
>> u'testdnsres' using dnsrecord_add
>> ----------------------------------------------------------------------
>> [...]
>>
>>     expected = u"Nameserver 'does.not.exist' does not have a
>> corresponding A/AAAA record"
>>     got = u"Nameserver 'does.not.exist.dnszone.test.' does not have a
>> corresponding A/AAAA record"
>>     path = ()
>>
>
> I updated the tests to use an absolute DNS record. All DNS tests should
> now succeed.
>
> Martin

It works fine now, ACK.

It would be nice to also test that the zone is appended, though.

-- 
Petr³