[Freeipa-devel] [PATCH] 147 Set network.http.sendRefererHeader to 2 on browser config

[Petr Vobornik]

On 06/05/2012 05:01 AM, Rob Crittenden wrote:
> Petr Vobornik wrote:
>> On 05/29/2012 11:29 PM, Rob Crittenden wrote:
>>> Petr Vobornik wrote:
>>>> IPA web UI isn't functional when browser doesn't send http headers.
>>>>
>>>> This patch adds a functionality which sets Firefox
>>>> network.http.sendRefererHeader configuration option to value '2' which
>>>> enables it.
>>>>
>>>> Possible values:
>>>> http://kb.mozillazine.org/Network.http.sendRefererHeader
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/2778
>>>
>>> Should we also add a message when referer is missing to check this
>>> setting in about:config?
>>
>> I'm not sure what you have in mind. We set the referer option so why
>> would user check it afterwards?
>>
>> Yes the ticket was about checking the option but: If user is configuring
>> the browser he wants the browser configured. So we should set all
>> options which are required. This is one of them. We have not been
>> notifying the user what was set, so I didn't add such notification for
>> this option now as well.
>>
>> We might want to notify the user what options were changed but it's not
>> the topic of this ticket.
>
> I was thinking more for already configured browsers who then later mess
> with this value. It fails in a very non-obvious way.
>
> rob

I'm attaching a patch which slightly changes the displayed error message 
from:

Missing or invalid HTTP Referer, missing

to:

Missing HTTP referer.
You have to configure your browser to send HTTP referer header.

Also I think we should document how to set it manually. We already have 
documentation for the rest of browser configuration.

-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0153-Custom-Web-UI-error-message-for-IPA-error-911.patch
Type: text/x-patch
Size: 2895 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120605/501ca965/attachment.bin>