[Freeipa-devel] [PATCH] 26 Fix '--random' param behaviour for host plugin

Rob Crittenden rcritten at redhat.com
Thu Jun 14 20:35:03 UTC 2012


Ondrej Hamada wrote:
> Improved options checking so that host-mod operation is not changing
> password for enrolled host when '--random' option is used.
>
> https://fedorahosted.org/freeipa/ticket/2799
>
> Updated set of characters that is used for generating random passwords
> for ipa hosts. Following characters were removed from the set: '"`\$<>
>
> https://fedorahosted.org/freeipa/ticket/2800

This works ok but it would be nice to have a test for both setting a 
password and random on an enrolled host to prevent regressions. We have 
some ipa-getkeytab tests already and these can be extended to test this 
I think.

Might be nice to mention in the inline comment the set of characters 
excluded and why.

rob




More information about the Freeipa-devel mailing list