[Freeipa-devel] [PATCH] 0010 Remove unnecessary mctx double checks

[Petr Spacek]

On 03/06/2012 01:49 PM, Adam Tkac wrote:
> On 03/06/2012 01:46 PM, Petr Spacek wrote:
>> Hello,
>>
>> this patch removes unnecessary double checks for isc_mem, which are
>> scattered through the code.
>>
>> This problem was mentioned yesterday (another) patch review:
>> https://www.redhat.com/archives/freeipa-devel/2012-March/msg00073.html
>>
>> On 03/05/2012 12:32 PM, Adam Tkac wrote:
>> >> > + REQUIRE(mctx != NULL);
>> > REQUIRE(mctx != NULL); is not needed, every isc_mem_* function
>> checks mctx
>> > validity.
>>
>> I checked each REQUIRE(mctx != NULL) and reference to "mctx" and Adam
>> is right :-D
>
> Ack, please push it to master.
>
> A
Pushed to master.

https://fedorahosted.org/bind-dyndb-ldap/changeset/15305dc1707dfa64dba993d33dfb7714b45d8362

Petr^2 Spacek

>
>>
>>
>> bind-dyndb-ldap-pspacek-0010-Remove-unnecessary-mctx-double-checks.patch
>>
>>
>> From 15305dc1707dfa64dba993d33dfb7714b45d8362 Mon Sep 17 00:00:00 2001
>> From: Petr Spacek<pspacek at redhat.com>
>> Date: Tue, 6 Mar 2012 13:30:05 +0100
>> Subject: [PATCH] Remove unnecessary mctx double checks. Signed-off-by:
>> Petr
>> Spacek<pspacek at redhat.com>