[Freeipa-devel] [PATCH] 234 Avoid deleting DNS zone when a context is reused

Martin Kosek mkosek at redhat.com
Thu Mar 8 13:57:36 UTC 2012


When dnsrecord-del pre_callback detects that the record does
not contain any records, it set a flag to connection context
and deletes the record object later. However, when more
dnsrecord-del share the same context (and this is the case of
"ipa-replica-manage del $MASTER" DNS cleanup), it may reuse
a positive flag from previous dnsrecord-del command and delete
the root DNS zone record and thus effectively delete the zone.

This patch makes sure that this flag is always initialized to
sane value in dnsrecord-del pre_callback to make sure that the DNS
zone is not deleted. It also fixes pre_callback function definition
to prevent adding attrs_list to "keys" parameter and thus confuse
developers.

https://fedorahosted.org/freeipa/ticket/2503

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-234-avoid-deleting-dns-zone-when-a-context-is-reused.patch
Type: text/x-patch
Size: 3196 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120308/dc8816cd/attachment.bin>


More information about the Freeipa-devel mailing list