[Freeipa-devel] [PATCH] 0011 Fix ticket #55: BIND cannot be shutdown correctly

[Petr Spacek]

On 03/12/2012 02:14 PM, Martin Kosek wrote:
> On Mon, 2012-03-12 at 08:46 -0400, Dmitri Pal wrote:
>> On 03/12/2012 08:15 AM, Petr Spacek wrote:
>>> Hello,
>>>
>>> this patch fixes annoying bug from ticket #55: BIND cannot be
>>> shutdown correctly, if psearch is enabled and LDAP connect fails
>>>
>>> Upstream ticket: https://fedorahosted.org/bind-dyndb-ldap/ticket/55
>>>
>>> It's trivial three line patch, so Adam ACKed it on IRC.
>>>
>>> Patch is already in master:
>>> https://fedorahosted.org/bind-dyndb-ldap/changeset/55d2886bb016adf3081a25eea616ce40f17d03e4
>>>
>>> I think it's annoying and fix is trivial, so I opened BZ ticket for
>>> RHEL6.3: https://bugzilla.redhat.com/show_bug.cgi?id=802375
>>>
>>>
>>> _______________________________________________
>>> Freeipa-devel mailing list
>>> Freeipa-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>
>> It seems that code has tabs which violates our coding standards. At
>> least the indentation looks wrong.
>>
>
> The whole bind-dyndb-ldap plugin use tabs for indentation, I would keep
> that unless we want to create mixed tab-space environment.
>
> I just see that Petr indented the statement with 2 tabs instead of one.
>
> Martin

Thanks for review, I missed double-tab. I agree with Martin, whole 
plugin and BIND actually use tabs for indentation.

Double-tab fixed: 
https://fedorahosted.org/bind-dyndb-ldap/changeset/284ee38e4cb55766317822a6db0ac2a776435fa5

Sorry for my mistake.

Petr^2 Spacek