[Freeipa-devel] [PATCH] 924 display both hex and decimal serial numbers

[Rob Crittenden]

Petr Viktorin wrote:
> On 03/13/2012 10:57 PM, Rob Crittenden wrote:
>> Jan Cholasta wrote:
> ..snip..
>>>
>>> This patch works for me, but let me repeat myself:
>>>
>>> > BTW, wouldn't it make sense to format serial numbers in the cert
>>> > plugin in the same way?
>>>
>>> Honza
>>>
>>
>> Updated.
>>
>> rob
>>
>>
>
>
> diff --git a/ipaserver/plugins/dogtag.py b/ipaserver/plugins/dogtag.py
> index
> b31058c1418f7f73854f7ac06701fb6f821a2e40..b56e04f4d8675c34cc5e7db42a1b45402ef79084
> 100644
> --- a/ipaserver/plugins/dogtag.py
> +++ b/ipaserver/plugins/dogtag.py
> @@ -609,6 +609,7 @@ def parse_profile_submit_result_xml(doc):
> if len(serial_number) == 1:
> serial_number = int(serial_number[0].text, 16) # parse as hex
> response_request['serial_number'] = serial_number
> + response['serial_number_hex'] = u'0x%X' % serial_number
>
>
> Why are you adding serial_number_hex to the entire response, when
> serial_number is on the individual response_request? (same in
> parse_revoke_cert_xml)
>
> I think you should also update the docstrings with the new item.
>

What docstrings are those?

These calls aren't needed at all. I submitted a new patch, 986, to 
remove them.

rob