[Freeipa-devel] [PATCH] 0021 Add CLI tests

[Petr Viktorin]

On 03/13/2012 12:23 PM, Petr Viktorin wrote:
> On 03/12/2012 09:18 PM, Rob Crittenden wrote:
>> Petr Viktorin wrote:
>>> Most of the tests we have check if the server does the right thing with
>>> XML-RPC calls. How the commandline is converted to command arguments,
>>> including interactive prompting, is untested.
>>> This patch adds some tests in this area. To do that I had to break up
>>> cli.run into more manageable pieces, and initialize the CLI plugins in
>>> test mode.
>>>
>>> Also I added nose's --nocapture option to the make-test script. With
>>> this it's possible to use pdb.set_trace() to drop into a debugger while
>>> running the tests.
>>>
>>>
>>> I went ahead and added a test for ticket 2484, fixed in Martin's patch
>>> 231 (Ignore case in yes/no prompts).
>>>
>>
>> John had done similar work with --nocapture a while back but it is still
>> pending. Perhaps we can merge his changes in with yours, they look
>> largely overlapping. His patch is [PATCH 54/54] ticet 2135 - enhance
>> make-test for debugging
>>
>> rob
>
> I guess it'll be better to make that a separate patch, then. This
> updated patch doesn't contain the make-test change.
>

Updating the patch to also test the CSV splitting in my patch 0015.04


-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0021-03-Add-CLI-parsing-tests.patch
Type: text/x-patch
Size: 9293 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120316/83bbc693/attachment.bin>