[Freeipa-devel] [PATCH] 242 Harden raw record processing in DNS plugin

Martin Kosek mkosek at redhat.com
Thu Mar 22 18:32:05 UTC 2012


On Thu, 2012-03-22 at 18:01 +0100, Petr Viktorin wrote:
> On 03/22/2012 05:38 PM, Martin Kosek wrote:
> > On Wed, 2012-03-21 at 16:58 +0100, Martin Kosek wrote:
> >> Few test cases are attached to the ticket.
> >> This patch depends on my patch 241.
> >> ---
> >> There were cases where DNS plugin was too tolerant in a raw DNS
> >> record option (--<rrtype-rec) processing. It let people specify
> >> DNS record parts options in dnsrecord-mod operations for some
> >> record without specifying the record that should be updated. It
> >> also ignored DNS record parts in dnsrecord-add operation when the
> >> raw DNS record value was already set via --<rrtype>-rec option.
> >>
> >> This patch hardens the processing and returns error in both
> >> described cases to make the processes clearer and more robust.
> >>
> >> All these use cases were also covered by new unit tests.
> >>
> >> https://fedorahosted.org/freeipa/ticket/2551
> >>
> >
> > My patch 241 was pushed, attaching a rebased patch 242 that applies
> > cleanly to ipa-2-2 branch.
> >
> > Martin
> >
> >
> 
> 
> ACK
> 

Pushed to master, ipa-2-2.

Martin




More information about the Freeipa-devel mailing list