[Freeipa-devel] [PATCH] 0029 Check expected error messages in tests

[Rob Crittenden]

Petr Viktorin wrote:
> On 03/20/2012 01:39 PM, Petr Viktorin wrote:
>> This patch adds checking error messages, not just types, to the XML-RPC
>> tests.
>> The checking is still somewhat hackish, since XML-RPC doesn't give us
>> structured error info, but it should protect against regressions on
>> issues like whether we put name or cli_name in a ValidationError.
>>
>> https://fedorahosted.org/freeipa/ticket/2549
>>
>
> Updated and rebased to current master.

NACK

automember wrongly was testing for non-existent users rather than 
automember rules but those should still be tested IMHO, perhaps with 
both types.

There is also some inconsistency. In host you use substitution to set 
the hostname in the error: '%s: host not found' % fqdn1 but in others 
(group, hostgroup for example) the name is hardcoded. I also noticed 
that some reasons are unicode and others are not.

rob