[Freeipa-devel] [PATCH] 70 Parse zone indices in IPv6 addresses in CheckedIPAddress

Martin Kosek mkosek at redhat.com
Tue Mar 27 08:43:36 UTC 2012


On Mon, 2012-03-19 at 14:02 +0100, Jan Cholasta wrote:
> https://fedorahosted.org/freeipa/ticket/2138
> 
> Honza
> 

This will work, I just think that a documentation of this issue can be
improved.

1) A short comment in the following part explaining why do we partition
by % would clarify it for non-IPv6 experts

+                except netaddr.AddrFormatError:
<<<
+                    addr = str(addr).partition('%')[0]
+                    addr = netaddr.IPAddress(addr, flags=self.netaddr_ip_flags)
+                    if addr.version != 6:

2) Patch comment can be improved as well

Thanks,
Martin




More information about the Freeipa-devel mailing list