[Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

[Petr Vobornik]

This bunch of patches are implementing ticket #2247. They introduce some 
new logic and types of internal objects. There might be design issues 
(mainly in state evaluation). I would appreciate some opinions on what 
might be improved.

See patch comments for more details.

What I think might be the main concerns:

Action list definition:
Now action lists are defined on facet level and facet header takes them 
from facet. Would in be better to define action list - the widget and 
actions separately. The widget could be defined in header and actions on 
facet level.

State evaluation:
The patches are adding support for some kind of state evaluation. The 
state is represented by array of string. I'm thinking that the design 
might not be robust. Is a string good enough? We might have a problem 
with conditions like to "have this particular access right' (#2318).
There are state_evaluators and state_listeners. They are practically the 
same but the execution point and parameters are different. Should they 
be somehow joined?

Code placement:
There's a lot of new objects and for some of them it is not clear to 
what code file they should be placed.

FYI: In close future I would like to address some problems in UI 
architecture. I'm in a middle of designing phase, so there is nothing to 
present at the moment. The main topics are:
* reduce the need of overriding methods when a new widgets or 
capabilities are added
* make it more declarative to enhance extendibility
It may be done by:
* better inheriting  model to support events
* build phases (preinit, init, postinit, create, load) to improve spec 
object creating and initialization of created object.
* path representation of an event/attribute/model property to support 
bindings to various events/attrs from anywhere
* introduce model and model bindings, converters between command 
output/model/human readable representation

-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0124-General-builder-support.patch
Type: text/x-patch
Size: 2605 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120502/98b254e5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0125-Action-lists.patch
Type: text/x-patch
Size: 22063 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120502/98b254e5/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0126-Control-buttons.patch
Type: text/x-patch
Size: 9506 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120502/98b254e5/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0127-Redefined-details-control-buttons.patch
Type: text/x-patch
Size: 6697 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120502/98b254e5/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0128-Redefined-search-control-buttons.patch
Type: text/x-patch
Size: 8198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120502/98b254e5/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0129-Hide-search-facet-add-delete-buttons-in-self-service.patch
Type: text/x-patch
Size: 8018 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120502/98b254e5/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0130-Batch-action-for-search-page-control-buttons.patch
Type: text/x-patch
Size: 1792 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120502/98b254e5/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0131-General-details-facet-actions.patch
Type: text/x-patch
Size: 7346 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120502/98b254e5/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0132-Consistent-change-of-entry-status.patch
Type: text/x-patch
Size: 21838 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120502/98b254e5/attachment-0008.bin>