[Freeipa-devel] [PATCH] 0052 Fix the pwpolicy_find post_callback

Petr Viktorin pviktori at redhat.com
Fri May 18 13:18:47 UTC 2012


The pwpolicy-find command had a bad condition that made IPA convert 
lifetime values for output only if those values were *not* being retrieved.
With this patch, the conversion routine is called unconditionally (it 
has its own check for presence of the attributes).

https://fedorahosted.org/freeipa/ticket/2726

Also, have the sorting code use a key function instead of a cmp; this is 
a Python best practice.
Improve a comment -- policies with higher priority are and always were 
at the *end* of the list, not the beginning. (I'm not sure if we want it 
this way?)

Regression test included.

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0052-Fix-the-pwpolicy_find-post_callback.patch
Type: text/x-patch
Size: 4947 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120518/d79469a2/attachment.bin>


More information about the Freeipa-devel mailing list