[Freeipa-devel] [PATCH] 0081 Support both unified samba and samba/samba4-packages

[Martin Kosek]

On 10/01/2012 11:24 AM, Alexander Bokovoy wrote:
> Hi,
> 
> The patch attached fixes Fedora build system issue with unified samba
> package (samba/samba4 packages got merged in Fedora 18 and Rawhide
> recently) since we depend on a wbclient.h header file path to which
> included versioned directory name previously (samba-4.0/ vs samba/).
> 

I am not convinced this is a correct approach, this was failing on my Fedora 18
instance anyway:

# make rpms
...
checking for NDR... yes
checking for SAMBAUTIL... yes
checking for samba-4.0/wbclient.h... no
checking for samba/wbclient.h... no
configure: error: samba/wbclient.h not found
make: *** [bootstrap-autogen] Error 1

The problem was that samba-devel package is no longer providing wbclient.h
header file:

# rpm -qR samba-devel-4.0.0-150.fc18.rc1.x86_64 | grep wbclient.h
#

I had a discussion with Andreas (CC-ed), the root cause was a missing
libwbclient-devel package which is the new provider of the samba-4.0/wbclient.h
file. He was also not aware of /usr/include/samba-4.0/ -> /usr/include/samba/
change.

I created a new patch with recommended approach (attached). Could you please
check if it is OK? It worked for me on both Fedora 17 and 18.

Thanks,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-318-add-support-for-unified-samba-packages.patch
Type: text/x-patch
Size: 2204 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20121001/f593b5b7/attachment.bin>