[Freeipa-devel] [PATCH] 1037 optimize restoring SELinux booleans

Petr Viktorin pviktori at redhat.com
Tue Oct 2 08:32:52 UTC 2012


On 10/01/2012 09:29 PM, Rob Crittenden wrote:
> Petr Viktorin wrote:
>> On 10/01/2012 04:41 PM, Rob Crittenden wrote:
>>> The web uninstall step can be very long because we restore two SELinux
>>> booleans individually. This patch combines them into a single step, and
>>> skips setting them if the values won't actually change.
>>>
>>> rob
>>>
>>>
>>
>> Is there a reason to not reuse the code that sets the values on install?
>> As far as I can tell it does the same thing slightly differently.
>>
>
> The differences are enough that trying to consolidate them would likely
> end up taking considerable more time, require considerable more testing,
> etc. It would be worthwhile to revisit this at the beginning of a new
> version, but at the end it seems safer to take the simplest route.
>
> rob

Well, okay then, ACK. But please keep the bug open.

-- 
Petr³




More information about the Freeipa-devel mailing list