[Freeipa-devel] [PATCH] convert the base platform modules into packages

[Petr Viktorin]

On 09/21/2012 04:57 PM, Timo Aaltonen wrote:
> Ok, so this is the first step before we can start to rewrite bits from
> ipaserver/install to make them support other distros. There are no real
> functional changes yet.
>
> had some dependency issues installing the resulting rpm's, so didn't
> test the install scripts but they should work :)
>
>

Hello,

I recommend giving the -M flag to git format-patch, so it's easier to 
see changes in the patch.


Your split of the fedora16 code into two modules is unfortunate: each 
tries to import the other one, and one is the other's parent. This would 
need special care to get working correctly.

The best option here would probably be to put restore_context & 
check_selinux_status into a separate submodule, so you don't need to 
import fedora16 from services.

Furthermore, in fedora16/__init__.py, you have:
     from ipapython.platform.fedora16.service import *
This imports everything from that module, including e.g. "redhat" or "os".
Please avoid star imports. List all the imported names explicitly, or 
import the module and then use qualified names.


Other than that, after a trivial rebase the patch seems to work fine on 
Fedora. Thanks!


-- 
Petr³