[Freeipa-devel] [PATCH] 323 Report ipa-upgradeconfig errors during RPM upgrade

[Rob Crittenden]

Petr Viktorin wrote:
> On 10/19/2012 08:15 AM, Martin Kosek wrote:
>> On 10/18/2012 05:51 PM, Rob Crittenden wrote:
>>> Martin Kosek wrote:
>>>> On 10/18/2012 05:22 PM, Rob Crittenden wrote:
>>>>> Martin Kosek wrote:
>>>>>> Report errors just like with ipa-ldap-updater. These messages
>>>>>> should warn
>>>>>> user that some parts of the upgrades may have not been successful and
>>>>>> he should follow up on them. Otherwise, user may not notice them
>>>>>> at all.
>>>>>>
>>>>>> ipa-upgradeconfig logging has been made consistent with
>>>>>> ipa-ldap-updater
>>>>>> logging - only error level or higher severity log messages are
>>>>>> printed
>>>>>> to stderr, with the same console format. A new debug log that an
>>>>>> upgrade
>>>>>> script has started was added to make log investigation easier.
>>>>>>
>>>>>> https://fedorahosted.org/freeipa/ticket/3157
>>>>>>
>>>>>> ---
>>>>>>
>>>>>> Reproducer is in Bugzilla attached to the ticket. With this patch,
>>>>>> RPM update
>>>>>> will report errors to user:
>>>>>>
>>>>>> # rpm -Uvh --force ~/freeipa-master/dist/rpms/freeipa-*
>>>>>> Preparing...
>>>>>> ########################################### [100%]
>>>>>>       1:freeipa-python
>>>>>> ########################################### [
>>>>>> 14%]
>>>>>>       2:freeipa-client
>>>>>> ########################################### [
>>>>>> 29%]
>>>>>>       3:freeipa-admintools
>>>>>> ########################################### [
>>>>>> 43%]
>>>>>>       4:freeipa-server
>>>>>> ########################################### [
>>>>>> 57%]
>>>>>> ERROR: Cannot update connections in /etc/named.conf: [Errno 13]
>>>>>> Permission
>>>>>> denied: '/etc/named.conf'
>>>>>>       5:freeipa-server-selinux
>>>>>> ########################################### [
>>>>>> 71%]
>>>>>>
>>>>>> 6:freeipa-server-trust-ad###########################################
>>>>>> [
>>>>>> 86%]
>>>>>>       7:freeipa-debuginfo
>>>>>> ###########################################
>>>>>> [100%]
>>>>>>
>>>>>> Martin
>>>>>
>>>>> Can you add an option to run in info mode (the equivalent of
>>>>> verbose=True)?
>>>>> Otherwise running from the cli returns nothing unless there is an
>>>>> error, I like
>>>>> some amount of output myself.
>>>>>
>>>>> rob
>>>>>
>>>>
>>>> ipa-upgradeconfig has a --debug option. I doubt that the output can
>>>> be more
>>>> verbose :-)
>>>>
>>>> Martin
>>>>
>>>
>>> Yeah, but there is no middle ground. You either get everything or
>>> nothing.
>>>
>>> rob
>>
>> Well, I can add it if you want it really hard. But from my
>> perspective, having
>> both "--debug" and "--verbose" is strange and it will also make it
>> inconsistent
>> with our other CLI tools where we have just --debug option
>> (ipa-ldap-updater,
>> ipa-replica-prepare, ipa-*-install).
>>
>
> I like ipa-replica-conncheck's approach: --debug (output everything) and
> --quiet (only output errors).
>

I guess I'm sad because we spent a fair bit of time adding pretty output 
to the script in non-debug mode which we are not suppressing.

ACK on quiet mode.

rob