[Freeipa-devel] [PATCHES] backport of Firefox extension to FreeIPA 2.2

[Petr Vobornik]

On 10/22/2012 05:01 PM, Martin Kosek wrote:
> On 10/17/2012 12:02 PM, Petr Vobornik wrote:
>> On 10/16/2012 06:10 PM, Endi Sukma Dewata wrote:
>>> On 10/12/2012 5:55 AM, Petr Viktorin wrote:
>>>> On 10/11/2012 02:55 PM, Petr Vobornik wrote:
>>>>> This bunch of patches is a backport of Firefox extension to FreeIPA 2.2.
>>>>>
>>>>> First apply pvoborni's patches then pviktori's.
>>>>
>>>> I tested several replication/upgrade scenarios. Upgrading from 2.2.0 and
>>>> to master works fine. ACK for the Python part.
>>>
>>> ACK for the JavaScript part.
>>
>> Pushed to ipa-2-2
>>>
>>> Just a minor issue, there's a typo in ipa_init.json and internal.py, I
>>> think it's supposed to use a curly bracket:
>>>
>>>     http://${host]/ipa/config/unauthorized.html
>>>
>>> This problem exists on both pvoborni-219-1 and pvoborni-219-2-2 patches.
>>>
>> Fixed, attaching updated and pushed patch for ipa-2-2. I will send patch for
>> 3.0 separately.
>>
>
> I started with IPA 2.2.1 release, but found out that the spec file is not right
> and some files are missing:
>
> Processing files: freeipa-debuginfo-2.2.1-0.fc17.x86_64
> Checking for unpackaged file(s): /usr/lib/rpm/check-files
> /root/freeipa-2-2-0/rpmbuild/BUILDROOT/freeipa-2.2.1-0.fc17.x86_64
> error: Installed (but unpackaged) file(s) found:
>     /etc/ipa/html/ffconfig.js
>     /etc/ipa/html/ffconfig_page.js
>
>
> RPM build errors:
>      Installed (but unpackaged) file(s) found:
>     /etc/ipa/html/ffconfig.js
>     /etc/ipa/html/ffconfig_page.js
> make: *** [rpms] Error 1
>
>
> Petr, can you please fix the spec file and check if the extension work is
> otherwise ok?
>
> Thanks,
> Martin
>

Hm, interdiff of 219-2-2 and 219-2-2-1 says that I ommitted changes in 
freeipa.spec.in in the latter patch. Weird. Anyway shame on me that I 
pushed it without proper check. Attaching diff patch which should fix it.
-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0224-RPM-spec-fix-for-ffconfig.js-and-ffconfig_page.js.patch
Type: text/x-patch
Size: 2026 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20121022/7677b861/attachment.bin>