[Freeipa-devel] [PATCH] ipa-client-automount: Add the autofs service if it doesn't exist

[Jakub Hrozek]

On Fri, Oct 26, 2012 at 06:51:46AM +0200, Jan Cholasta wrote:
> Hi,
> 
> On 25.10.2012 20:29, Rob Crittenden wrote:
> >Jakub Hrozek wrote:
> >>The script was only activating the service, which was failing if there
> >>was no such service.
> >>
> >
> >So simple. ACK, pushed to master and ipa-3-0
> >
> >Note, I added the ticket number to the commit message.
> >
> >rob
> >
> 
> Sorry for replying too late, but you might want to take a look on
> how this is done for SSH in ipa-client-install, as it also checks if
> SSSD was built with support for the feature.
> 
> Honza

You're right, that seems a little more defensive and little more
Pythonic (and also solves Rob's concern about a proper error message not
being printed if the operation failed).

I'll send a new patch that improves the error handling. Thanks for the
review!