[Freeipa-devel] [PATCH 0060] Fix zone delete in ldap_zone_delete2()

Petr Spacek pspacek at redhat.com
Mon Sep 24 15:59:15 UTC 2012


On 09/24/2012 03:00 PM, Adam Tkac wrote:
> On Thu, Sep 13, 2012 at 01:36:32PM +0200, Petr Spacek wrote:
>> Hello,
>>
>>      Fix zone delete in ldap_zone_delete2(). This fixes two race
>>      conditions during BIND reload:
>>
>>      - failing assert in destroy_ldap_connection() DESTROYLOCK:
>>      ((pthread_mutex_destroy(&ldap_conn->lock) == 0) ? 0 : 34) == 0
>>
>>      - use-after-free in call:
>>      ldap_cache_enabled(cache=0xdededededededede)
>
> Ack.
>
> When pushing, please consider if "race-condition" is good description. From my
> point of view better is "fix extraction of zone FQDN when destroing LDAP
> instance" or something like that.
>
> Regards, Adam

Pushed with amended commit message:

e6286d061d12a604fa8c4c3eb282df7ec17b4cbe

Petr^2 Spacek




More information about the Freeipa-devel mailing list