[Freeipa-devel] [PATCH] 0085 Don't use bare except: clauses in ipa-client-install

Martin Kosek mkosek at redhat.com
Thu Sep 27 13:24:57 UTC 2012


On 09/25/2012 05:59 PM, Petr Viktorin wrote:
> https://fedorahosted.org/freeipa/ticket/2941
> 
> Simo, do you remember how you configured resolv.conf and when you pressed
> Ctrl+C? There's a lot of code called from ipa-replica-install that could cause
> the bug.
> 
> Here I went for the most obvious places where we ignore KeyboardInterrupt. I
> will look for others.
> 
> I'll also do a more thorough audit of the installer code when I work on
> https://fedorahosted.org/freeipa/ticket/2652.
> 
> 

I did not reproduce the issue either, but the changes you made are OK and
should improve the situation at minimum. The issue may have been fixed during
3.0 development as a side-effect of other patch.

ACK. Pushed to master, ipa-3-0.

Martin




More information about the Freeipa-devel mailing list