[Freeipa-devel] [PATCH] 203 Notify success on add, delete and update

[Petr Vobornik]

On 09/05/2012 07:25 PM, Endi Sukma Dewata wrote:
> On 9/3/2012 8:35 AM, Petr Vobornik wrote:
>> Notification of success was added to:
>>   * details facet: update
>>   * association facet and association widget: add, delete items
>>   * attribute facet: delete items (notification of add should be handled
>> in entity adder dialog)
>>   * sudo rule: add, remove option
>>   * dnsrecord: add, update, delete
>>
>> https://fedorahosted.org/freeipa/ticket/2977
>
> ACK. Some minor issues below:

Pushed to master.

>
> 1. The notification for operations involving multiple entries are a bit
> inconsistent. In the search facet deleting entries will generate
> "Selected entries were deleted." Enabling/disabling entries will
> generate "<n> items were enabled/disabled". In the association facet,
> HBAC/sudo rules, adding/deleting entries will generate "Items
> added/removed." For sudo options it's "Option/Option(s) added/removed."
>

To change notification we should also review confirmation messages. For 
example delete message reflect 'Do you want to delete selected items'.

I guess if we want to change it, we should make them more specific and 
avoid general words like items or entries. Btw which of the two is better?

> 2. The notification for operations involving a single entry are a bit
> consistent too, but I think this is an existing issue. If you add an
> entry the notification will say "<entity> successfully added". It
> doesn't show the primary key which may be generated by the server. As a
> comparison if you delete an entry from the details page it will say
> "Deleted <entity> '<primary key>'", and for update operation "<entity>
> <primary key> updated."
>

In adder dialog we should probably used the message sent by the server, 
as we do in the other cases.

> 3. Also existing issue, if you add using "Add and Add Another" the
> notification doesn't fade away, does it matter?

I don't think we should change it. Because in the time when it would 
fade away user will be filling some fields. User might be surprised by 
sudden move in the dialog.

>
> Feel free to address this separately.
>

-- 
Petr Vobornik